feat: skip trailers/pre-rolls inaccessible to the current user (v1.0.0.9)

Filters trailer pool items and pre-roll/feature pre-roll bumpers using
BaseItem.IsVisibleStandalone(user), so users without access to the
relevant library are never handed an item they can't actually play —
some Cinema Mode clients hang indefinitely in that case.

Jellyfin.Plugin.CinemaTrailers4Jellyfins/Jellyfin.Plugin.CinemaTrailers4Jellyfins.csproj

@@ -3,8 +3,8 @@
   <PropertyGroup>
     <TargetFramework>net9.0</TargetFramework>
     <RootNamespace>Jellyfin.Plugin.CinemaTrailers4Jellyfins</RootNamespace>
-    <AssemblyVersion>1.0.0.8</AssemblyVersion>
+    <AssemblyVersion>1.0.0.9</AssemblyVersion>
-    <FileVersion>1.0.0.8</FileVersion>
+    <FileVersion>1.0.0.9</FileVersion>
     <Nullable>enable</Nullable>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
     <TreatWarningsAsErrors>false</TreatWarningsAsErrors>

Jellyfin.Plugin.CinemaTrailers4Jellyfins/Services/TrailerIntroProvider.cs

@@ -111,7 +111,7 @@ namespace Jellyfin.Plugin.CinemaTrailers4Jellyfins.Services
 
             if (preRollEnabled)
             {
-                var preRoll = GetRandomLibraryMovieIntro("Trailer Pre-Roll", config.TrailerPreRollLibraryId, item.Id);
+                var preRoll = GetRandomLibraryMovieIntro("Trailer Pre-Roll", config.TrailerPreRollLibraryId, item.Id, user);
                 if (preRoll != null)
                     intros.Add(preRoll);
             }
@@ -129,6 +129,9 @@ namespace Jellyfin.Plugin.CinemaTrailers4Jellyfins.Services
                     .Where(m =>
                         m.Path?.StartsWith(outputFolder, StringComparison.OrdinalIgnoreCase) == true
                         && m.LocalTrailers.Count > 0
+                        // Skip items the user can't actually play (e.g. library not in their access list) —
+                        // some clients hang indefinitely trying to play an inaccessible item.
+                        && m.IsVisibleStandalone(user)
                         // Keep TV show trailers for episodes and movie trailers for movies separate.
                         && m.Tags.Contains(TrailerTags.TvShow, StringComparer.OrdinalIgnoreCase) == isEpisode)
                     .SelectMany(m => m.LocalTrailers.Select(t => (Movie: m, Trailer: t)))
@@ -165,7 +168,7 @@ namespace Jellyfin.Plugin.CinemaTrailers4Jellyfins.Services
 
             if (featurePreRollEnabled)
             {
-                var featureRoll = GetRandomLibraryMovieIntro("Feature Pre-Roll", config.FeaturePreRollLibraryId, item.Id);
+                var featureRoll = GetRandomLibraryMovieIntro("Feature Pre-Roll", config.FeaturePreRollLibraryId, item.Id, user);
                 if (featureRoll != null)
                     intros.Add(featureRoll);
             }
@@ -182,7 +185,7 @@ namespace Jellyfin.Plugin.CinemaTrailers4Jellyfins.Services
         /// Picks a random Movie from the given Jellyfin library (VirtualFolder ItemId) to use as a
         /// pre-roll/post-roll bumper, excluding the item currently being played.
         /// </summary>
-        private IntroInfo? GetRandomLibraryMovieIntro(string label, string libraryId, Guid excludeId)
+        private IntroInfo? GetRandomLibraryMovieIntro(string label, string libraryId, Guid excludeId, User user)
         {
             if (!Guid.TryParse(libraryId, out var parsedId))
             {
@@ -204,14 +207,14 @@ namespace Jellyfin.Plugin.CinemaTrailers4Jellyfins.Services
 
             var movies = folder.GetRecursiveChildren()
                 .OfType<Movie>()
-                .Where(m => m.Id != excludeId)
+                .Where(m => m.Id != excludeId && m.IsVisibleStandalone(user))
                 .ToList();
 
             if (movies.Count == 0)
             {
                 _logger.LogInformation(
-                    "|CinemaTrailers4Jellyfins| {Label} library {LibraryId} has no eligible Movie items. "
+                    "|CinemaTrailers4Jellyfins| {Label} library {LibraryId} has no eligible Movie items visible to this user. "
-                    + "Ensure the library has been scanned and contains at least one other Movie.",
+                    + "Ensure the library has been scanned, contains at least one other Movie, and is in this user's library access list.",
                     label,
                     parsedId);
                 return null;

build.yaml

@@ -1,5 +1,5 @@
 ---
-version: 1.0.0.8
+version: 1.0.0.9
 name: CinemaTrailers4Jellyfins
 guid: b581493e-1046-40ed-b6dc-cb8027624984
 description: >
@@ -12,10 +12,10 @@ category: General
 owner: 514mart
 targetAbi: 10.11.0.0
 changelog:
-  - Fix Trailer Pre-Roll / Feature Pre-Roll bumpers not being found — the
+  - Skip trailers and pre-roll/feature pre-roll bumpers the current user
-    library lookup now walks the configured library folder's children
+    can't actually access (e.g. a library not in their library access list)
-    directly instead of relying on TopParentIds matching, which could fail
+    — some Cinema Mode clients hang indefinitely trying to play an
-    to match movies even when they appear correctly in the library
+    inaccessible item, so these are now filtered out per-user instead
 
 dotnetProjects:
   - name: Jellyfin.Plugin.CinemaTrailers4Jellyfins