fix: pre-roll/feature pre-roll bumpers not found in library (v1.0.0.8)
All checks were successful
Publish Release / release (push) Successful in 8s

TopParentIds-based queries could fail to match Movie items in the
configured pre-roll library even when they appear correctly in the
Jellyfin UI. Look up the library Folder by ID and walk its recursive
children directly instead, matching the path-based approach already
used for the trailer pool.
This commit is contained in:
Martin
2026-06-10 11:27:52 -04:00
parent 99798b5174
commit adfa570569
3 changed files with 17 additions and 14 deletions

View File

@@ -3,8 +3,8 @@
<PropertyGroup> <PropertyGroup>
<TargetFramework>net9.0</TargetFramework> <TargetFramework>net9.0</TargetFramework>
<RootNamespace>Jellyfin.Plugin.CinemaTrailers4Jellyfins</RootNamespace> <RootNamespace>Jellyfin.Plugin.CinemaTrailers4Jellyfins</RootNamespace>
<AssemblyVersion>1.0.0.7</AssemblyVersion> <AssemblyVersion>1.0.0.8</AssemblyVersion>
<FileVersion>1.0.0.7</FileVersion> <FileVersion>1.0.0.8</FileVersion>
<Nullable>enable</Nullable> <Nullable>enable</Nullable>
<GenerateDocumentationFile>false</GenerateDocumentationFile> <GenerateDocumentationFile>false</GenerateDocumentationFile>
<TreatWarningsAsErrors>false</TreatWarningsAsErrors> <TreatWarningsAsErrors>false</TreatWarningsAsErrors>

View File

@@ -193,13 +193,16 @@ namespace Jellyfin.Plugin.CinemaTrailers4Jellyfins.Services
return null; return null;
} }
var movies = _libraryManager if (_libraryManager.GetItemById(parsedId) is not Folder folder)
.GetItemList(new InternalItemsQuery {
{ _logger.LogWarning(
IncludeItemTypes = new[] { BaseItemKind.Movie }, "|CinemaTrailers4Jellyfins| {Label} library {LibraryId} could not be found.",
TopParentIds = new[] { parsedId }, label,
Recursive = true, parsedId);
}) return null;
}
var movies = folder.GetRecursiveChildren()
.OfType<Movie>() .OfType<Movie>()
.Where(m => m.Id != excludeId) .Where(m => m.Id != excludeId)
.ToList(); .ToList();

View File

@@ -1,5 +1,5 @@
--- ---
version: 1.0.0.7 version: 1.0.0.8
name: CinemaTrailers4Jellyfins name: CinemaTrailers4Jellyfins
guid: b581493e-1046-40ed-b6dc-cb8027624984 guid: b581493e-1046-40ed-b6dc-cb8027624984
description: > description: >
@@ -12,10 +12,10 @@ category: General
owner: 514mart owner: 514mart
targetAbi: 10.11.0.0 targetAbi: 10.11.0.0
changelog: changelog:
- Add Information-level diagnostic logging to IIntroProvider.GetIntros — logs - Fix Trailer Pre-Roll / Feature Pre-Roll bumpers not being found — the
every call (item, path, and which features are enabled), why an item is library lookup now walks the configured library folder's children
skipped, and the outcome of Trailer/Feature Pre-Roll lookups, to help directly instead of relying on TopParentIds matching, which could fail
troubleshoot why a pre-roll bumper isn't playing to match movies even when they appear correctly in the library
dotnetProjects: dotnetProjects:
- name: Jellyfin.Plugin.CinemaTrailers4Jellyfins - name: Jellyfin.Plugin.CinemaTrailers4Jellyfins